Added support for extending limit for quick filter through configuration#26
Merged
jakob101 merged 4 commits intodawsbot:masterfrom Apr 22, 2018
Merged
Added support for extending limit for quick filter through configuration#26jakob101 merged 4 commits intodawsbot:masterfrom
jakob101 merged 4 commits intodawsbot:masterfrom
Conversation
Contributor
Author
|
@jakob101 If you merge this, then our team will start using this plugin. |
added 2 commits
April 22, 2018 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing more than 1000 options might lead to performance issues and surely was a good check.
However, I wanted quick pick anyway despite a performance drop of ~1 sec because I had about 2K files in my project and it was fine by me.
So did all the other people in my team wanted this part of the extension become configurable.
So, a new external configuration is:
or just could be any number that a user prefers to use.
The user knows that they'll be causing the drop in performance but surely would prefer the suggestions to show up and lesser number of hits on the keyboard.
The default is still 1000.